chore: Android Move graphql queries in the code#507
Merged
abelonogov-ld merged 1 commit intomainfrom Apr 28, 2026
Merged
Conversation
Vadman97
approved these changes
Apr 28, 2026
abelonogov-ld
added a commit
that referenced
this pull request
Apr 28, 2026
…bservability-sdk into andrey/dotnet-otel-update * 'andrey/dotnet-otel-update' of github.com:launchdarkly/observability-sdk: chore: Android Move graphql queries in the code (#507)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move graphql queries into code files not load them every time in runtime, weirdly it helps to make code compatibkle with .NET10 and usable in the Java server code.
Note
Medium Risk
Medium risk because it changes the public
GraphQLClient.executesignature and shifts query text from resources to code, where string formatting/escaping mistakes could break production GraphQL calls.Overview
GraphQL queries are now inlined in code instead of loaded from resources at runtime.
GraphQLClient.executenow takes aquery: Stringand the internalloadQueryresource loader is removed.SamplingApiServiceandSessionReplayApiServiceembed their GraphQL operations as Kotlin multiline strings and pass them directly toexecute, and the corresponding.graphqlresource files (plus the test query resource) are deleted. Tests are updated accordingly, including removing the missing-file test case and adjusting mocks to accept the newexecuteparameter.Reviewed by Cursor Bugbot for commit ffa3cc6. Bugbot is set up for automated code reviews on this repo. Configure here.